Skip to content

Make use of well-ordered hooks from hk-config - #111

Merged
nnutter merged 3 commits into
masterfrom
hk-hooks
Nov 5, 2026
Merged

nnutter merged 3 commits into
masterfrom
hk-hooks

Conversation

@nnutter

@nnutter nnutter commented Nov 5, 2026 •

Copy link
Copy Markdown
Owner

No description provided.

gohawk reports a failure-to-open result as a missing release, because a
return under `errors.Is(err, os.ErrNotExist)` or `errors.Is(err, os.ErrExist)`
does not prove that the open failed, so the analyzer cannot rule out an
open resource on that path. Testing the error first gives the same result
for every input and shows that the resource was never obtained.

Behavior is unchanged; the go group's new gohawk step now passes.
A workflow-level `contents: write` lets the build jobs push commits and
create releases, and the build restores a mise cache that a pull request
can populate. jactionlint reports both when a workflow builds on a tag.

The top level now grants nothing, the build jobs read the repository,
and only the publish job writes, with the cache off so no cache entry
from another branch can reach the published artifacts.
The config listed every step and wrote the depends graph by hand, which
repeats the order rules that hk-config now owns and drifts when a group
gains a step. Hooks.all builds the 4 hooks from the groups it is given
and orders their steps, so the config names go, toml, yaml, and
agentskills and imports no builtin of its own.

The hook defaults add a mise check and jactionlint, and the go group
adds gohawk, so both tools join mise.toml. jactionlint reads the runner
labels that the workflows name, so no extra label file is needed.
@nnutter nnutter changed the title Take the hook steps and their order from hk-config Make use of well-ordered hooks from hk-config Nov 5, 2026
@nnutter
nnutter merged commit 7469712 into master Nov 5, 2026
3 checks passed
@nnutter
nnutter deleted the hk-hooks branch November 5, 2026 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant